[stable-3.8] Fix NPE in PreviewMediaFragment#4594
Merged
Merged
Conversation
backportbot-nextcloud
Bot
requested review from
AndyScherzinger,
ezaquarii and
tobiasKaminsky
October 2, 2019 07:03
tobiasKaminsky
approved these changes
Oct 2, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.8)
|
Codecov Report
@@ Coverage Diff @@
## stable-3.8 #4594 +/- ##
================================================
+ Coverage 16.99% 17.01% +0.02%
Complexity 1 1
================================================
Files 361 361
Lines 32000 32001 +1
Branches 4511 4512 +1
================================================
+ Hits 5438 5445 +7
+ Misses 25659 25652 -7
- Partials 903 904 +1
|
Fragment can be detached before async task finishes. Detached fragment has no context and getString() fails with NPE. Fixes #4412 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
backport/4577/stable-3.8
branch
from
October 2, 2019 07:15
8eb4823 to
7ef8981
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11070.apk |
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.8)
|
AndyScherzinger
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #4577